Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Fixed Format String to Serialize Timestamp into Query String #26388

Closed
wants to merge 4 commits into from
Closed

Use Fixed Format String to Serialize Timestamp into Query String #26388

wants to merge 4 commits into from

Conversation

msJinLei
Copy link
Contributor

@msJinLei msJinLei commented Oct 18, 2024 •
edited
Loading

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 18, 2024 •
edited
Loading

🔄Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.Aks
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.ApplicationInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
❌Az.CosmosDB
❌Build
❌PowerShell Core - Windows
Type Code Position Detail
❌ CS1061 D:\a_work\1\s\src\CosmosDB\CosmosDB\Table\RestoreAzCosmosDBTable.cs(173,190) 'DateTime' does not contain a definition for 'ToInvariantString' and no accessible extension method 'ToInvariantString' accepting a first argument of type 'DateTime' could be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\CosmosDB\CosmosDB\CosmosDB.csproj]
❌ CS1061 D:\a_work\1\s\src\CosmosDB\CosmosDB\Table\RestoreAzCosmosDBTable.cs(173,230) 'DateTime' does not contain a definition for 'ToInvariantString' and no accessible extension method 'ToInvariantString' accepting a first argument of type 'DateTime' could be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\CosmosDB\CosmosDB\CosmosDB.csproj]
❌ CS1061 D:\a_work\1\s\src\CosmosDB\CosmosDB\CosmosDBAccount\RestoreAzCosmosDBAccount.cs(143,48) 'DateTime' does not contain a definition for 'ToInvariantString' and no accessible extension method 'ToInvariantString' accepting a first argument of type 'DateTime' could be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\CosmosDB\CosmosDB\CosmosDB.csproj]
❌ CS1061 D:\a_work\1\s\src\CosmosDB\CosmosDB\CosmosDBAccount\RestoreAzCosmosDBAccount.cs(161,44) 'DateTime' does not contain a definition for 'ToInvariantString' and no accessible extension method 'ToInvariantString' accepting a first argument of type 'DateTime' could be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\CosmosDB\CosmosDB\CosmosDB.csproj]
❌ CS1061 D:\a_work\1\s\src\CosmosDB\CosmosDB\CosmosDBAccount\RestoreAzCosmosDBAccount.cs(179,44) 'DateTime' does not contain a definition for 'ToInvariantString' and no accessible extension method 'ToInvariantString' accepting a first argument of type 'DateTime' could be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\CosmosDB\CosmosDB\CosmosDB.csproj]
❌ CS1061 D:\a_work\1\s\src\CosmosDB\CosmosDB\CosmosDBAccount\RestoreAzCosmosDBAccount.cs(197,44) 'DateTime' does not contain a definition for 'ToInvariantString' and no accessible extension method 'ToInvariantString' accepting a first argument of type 'DateTime' could be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\CosmosDB\CosmosDB\CosmosDB.csproj]
❌Windows PowerShell - Windows
Type Code Position Detail
❌ CS1061 D:\a_work\1\s\src\CosmosDB\CosmosDB\Table\RestoreAzCosmosDBTable.cs(173,190) 'DateTime' does not contain a definition for 'ToInvariantString' and no accessible extension method 'ToInvariantString' accepting a first argument of type 'DateTime' could be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\CosmosDB\CosmosDB\CosmosDB.csproj]
❌ CS1061 D:\a_work\1\s\src\CosmosDB\CosmosDB\Table\RestoreAzCosmosDBTable.cs(173,230) 'DateTime' does not contain a definition for 'ToInvariantString' and no accessible extension method 'ToInvariantString' accepting a first argument of type 'DateTime' could be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\CosmosDB\CosmosDB\CosmosDB.csproj]
❌ CS1061 D:\a_work\1\s\src\CosmosDB\CosmosDB\CosmosDBAccount\RestoreAzCosmosDBAccount.cs(143,48) 'DateTime' does not contain a definition for 'ToInvariantString' and no accessible extension method 'ToInvariantString' accepting a first argument of type 'DateTime' could be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\CosmosDB\CosmosDB\CosmosDB.csproj]
❌ CS1061 D:\a_work\1\s\src\CosmosDB\CosmosDB\CosmosDBAccount\RestoreAzCosmosDBAccount.cs(161,44) 'DateTime' does not contain a definition for 'ToInvariantString' and no accessible extension method 'ToInvariantString' accepting a first argument of type 'DateTime' could be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\CosmosDB\CosmosDB\CosmosDB.csproj]
❌ CS1061 D:\a_work\1\s\src\CosmosDB\CosmosDB\CosmosDBAccount\RestoreAzCosmosDBAccount.cs(179,44) 'DateTime' does not contain a definition for 'ToInvariantString' and no accessible extension method 'ToInvariantString' accepting a first argument of type 'DateTime' could be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\CosmosDB\CosmosDB\CosmosDB.csproj]
❌ CS1061 D:\a_work\1\s\src\CosmosDB\CosmosDB\CosmosDBAccount\RestoreAzCosmosDBAccount.cs(197,44) 'DateTime' does not contain a definition for 'ToInvariantString' and no accessible extension method 'ToInvariantString' accepting a first argument of type 'DateTime' could be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\CosmosDB\CosmosDB\CosmosDB.csproj]
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
️✔️Az.EventHub
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Az.Functions
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.KubernetesConfiguration
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Az.Monitor
❌Build
❌PowerShell Core - Windows
Type Code Position Detail
❌ CS1061 D:\a_work\1\s\src\Monitor\Monitor\OutputClasses\CustomPrinter.cs(78,44) 'DateTime' does not contain a definition for 'ToInvariantString' and no accessible extension method 'ToInvariantString' accepting a first argument of type 'DateTime' could be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Monitor\Monitor\Monitor.csproj]
❌Windows PowerShell - Windows
Type Code Position Detail
❌ CS1061 D:\a_work\1\s\src\Monitor\Monitor\OutputClasses\CustomPrinter.cs(78,44) 'DateTime' does not contain a definition for 'ToInvariantString' and no accessible extension method 'ToInvariantString' accepting a first argument of type 'DateTime' could be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Monitor\Monitor\Monitor.csproj]
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Az.PostgreSql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Az.Purview
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.Synapse
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.Websites
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Generated Sdk Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows

@github-actions GitHub Actions
Copy link

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

@msJinLei msJinLei mentioned this pull request Oct 18, 2024
Closed
6 tasks
@msJinLei msJinLei force-pushed the jinlei/invariantculture branch from aceceb1 to 753793e Compare October 18, 2024 18:48
@msJinLei msJinLei mentioned this pull request Oct 18, 2024
Open
@msJinLei
Copy link
Contributor Author

Not going to fix and just skip the failed test cases see #26425

@msJinLei msJinLei closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Do Not Merge 🚫
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@msJinLei